[9.2] [Security Solution][Alerts] Reset selected rows when page index changes (#243729)#244671
Merged
Merged
Conversation
…es (elastic#243729) > [!warning] > **I am not sure this is the right way to fix this issue**. > If you are a reviewer and have a better idea, your suggestion is more than welcome ## Summary Addresses elastic#243190 ### 🛑 The problem As highlighted in the aforementioned issue, the selection of rows in the alerts table would persist when turning page. This is a screen-recording of the issue: https://github.com/user-attachments/assets/a3b3444a-9253-41d1-b89b-072907c7043c ### 🔍 Context - Clearing the selection after changing page is what was happening in previous versions of kibana - I have noticed that in discovery we do not do this, but in other parts of kibana we do - I couldn't really narrow the commit that caused this to happen, so I have implemented my own solution ### 💡 The solution I have added a "dependency" to the effect that resets the selection when the page size changes — I thought it was the appropriate place to do it. (cherry picked from commit cc0f9c9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto9.2:Questions ?
Please refer to the Backport tool documentation